[all-commits] [llvm/llvm-project] 4ebe9b: Revert "Correctly identify iOS simulator processes...

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ebe9b498da5cfec48a91f50241c686153ab6122
      https://github.com/llvm/llvm-project/commit/4ebe9b498da5cfec48a91f50241c686153ab6122
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    R lldb/test/API/functionalities/gdb_remote_client/TestIOSSimulator.py
    M lldb/test/API/functionalities/gdb_remote_client/TestWasm.py
    M lldb/test/API/functionalities/gdb_remote_client/gdbclientutils.py
    M lldb/tools/debugserver/source/MacOSX/MachProcess.mm

  Log Message:
  -----------
  Revert "Correctly identify iOS simulator processes in debugserver."

This reverts commit 59d816d88464e93a89e0d9c80c8855ab1f453541.

It broke TestGDBRemoteClient.


  Commit: 000847f8bed4a8624de3e39ff90af721cf8a1e2b
      https://github.com/llvm/llvm-project/commit/000847f8bed4a8624de3e39ff90af721cf8a1e2b
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    A lldb/test/API/functionalities/gdb_remote_client/TestIOSSimulator.py
    M lldb/tools/debugserver/source/MacOSX/MachProcess.mm

  Log Message:
  -----------
  Correctly identify iOS simulator processes in debugserver.

Starting with iOS 13 simulator binaries are identified with an
explicit platform in the new LC_BUILD_VERSION load command.

On older deployment targets using the LC_VERSION_MIN load commands,
this patch detects when an ios process runs on a macOS host and
updates the target triple with the "simulator" environment
accordingly.

(Patch re-applied with bugfix this time).

This is part of https://bugs.swift.org/browse/SR-11971

rdar://problem/58438125

Differential Revision: https://reviews.llvm.org/D75696


Compare: https://github.com/llvm/llvm-project/compare/fc3cdd2ee73f...000847f8bed4