[all-commits] [llvm/llvm-project] 0ba553: [MC] Allowing the use of $-prefixed integer as asm...

Lucas Duarte Prates via All-commits all-commits at lists.llvm.org
Fri Mar 6 08:27:56 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ba553d153e65b283c7934c3f061ad0487f03ba6
      https://github.com/llvm/llvm-project/commit/0ba553d153e65b283c7934c3f061ad0487f03ba6
  Author: Lucas Prates <lucas.prates at arm.com>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M llvm/lib/MC/MCParser/AsmParser.cpp
    M llvm/test/MC/ARM/arm-branches.s
    R llvm/test/MC/MachO/bad-dollar.s
    A llvm/test/MC/MachO/dollar-identifier.s
    M llvm/test/MC/Mips/cpsetup-bad.s
    M llvm/test/MC/Mips/invalid-instructions-spellcheck.s

  Log Message:
  -----------
  [MC] Allowing the use of $-prefixed integer as asm identifiers

Summary:
Dollar signed prefixed integers were not allowed by the AsmParser to be
used as Identifiers, differing from the GNU assembler behavior.

This patch updates the parsing of Identifiers to consider such cases as
valid, where the identifier string includes the $ prefix itself. As the
Lexer currently splits these occurrences into separate tokens, those
need to be combined by the AsmParser itself.

Reviewers: efriedma, chill

Reviewed By: efriedma

Subscribers: sdardis, hiraditya, jrtc27, atanasyan, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75111




More information about the All-commits mailing list