[all-commits] [llvm/llvm-project] 92c0cd: [lldb/Disassembler] Move address resolution into t...

Pavel Labath via All-commits all-commits at lists.llvm.org
Fri Mar 6 02:23:52 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 92c0cda92847053297ad1f083f13469ff7b43871
      https://github.com/llvm/llvm-project/commit/92c0cda92847053297ad1f083f13469ff7b43871
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M lldb/include/lldb/Core/Disassembler.h
    M lldb/source/Core/Disassembler.cpp

  Log Message:
  -----------
  [lldb/Disassembler] Move address resolution into the ParseInstructions function

The static Disassembler can be thought of as shorthands for three
operations:
- fetch an appropriate disassembler instance (FindPluginForTarget)
- ask it to dissassemble some bytes (ParseInstructions)
- ask it to dump the disassembled instructions (PrintInstructions)

The only thing that's standing in the way of this interpretation is that
the Disassemble function also does some address resolution before
calling ParseInstructions. This patch moves this functionality into
ParseInstructions so that it is available to users who call
ParseInstructions directly.




More information about the All-commits mailing list