[all-commits] [llvm/llvm-project] a130be: [LLD][NFC] Remove getOffsetInFile() workaround.

avl-llvm via All-commits all-commits at lists.llvm.org
Thu Mar 5 04:52:54 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a130be6ac51656407fd97208d13b763aaf37a7f3
      https://github.com/llvm/llvm-project/commit/a130be6ac51656407fd97208d13b763aaf37a7f3
  Author: Alexey Lapshin <a.v.lapshin at mail.ru>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M lld/ELF/DWARF.cpp
    M lld/ELF/InputFiles.cpp
    M lld/ELF/SyntheticSections.cpp

  Log Message:
  -----------
  [LLD][NFC] Remove getOffsetInFile() workaround.

Summary:
LLD has workaround for the times when SectionIndex was not passed properly:

LT->getFileLineInfoForAddress(
      S->getOffsetInFile() + Offset, nullptr,
      DILineInfoSpecifier::FileLineInfoKind::AbsoluteFilePath, Info));

S->getOffsetInFile() was added to differentiate offsets between
various sections. Now SectionIndex is properly specified.
Thus it is not necessary to use getOffsetInFile() workaround.
See https://reviews.llvm.org/D58194, https://reviews.llvm.org/D58357.

This patch removes getOffsetInFile() workaround.

Reviewers: ruiu, grimar, MaskRay, espindola

Reviewed By: grimar, MaskRay

Subscribers: emaste, arichardson, llvm-commits

Tags: #llvm, #lld

Differential Revision: https://reviews.llvm.org/D75636




More information about the All-commits mailing list