[all-commits] [llvm/llvm-project] 1a8375: [DebugInfo] Refine the condition to detect CIEs.

[Igor Kudrin via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a837569db3b611c6bd0b891b79f1585be20c323
      https://github.com/llvm/llvm-project/commit/1a837569db3b611c6bd0b891b79f1585be20c323
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
    A llvm/test/DebugInfo/X86/debug-frame-cie-id-dwarf64.s
    A llvm/test/DebugInfo/X86/eh-frame-cie-id.s

  Log Message:
  -----------
  [DebugInfo] Refine the condition to detect CIEs.

The condition was not accurate enough and could interpret some FDEs in
.eh_frame or 64-bit DWARF .debug_frame sections as CIEs. Even though
such FDEs are unlikely in a normal situation, the wrong interpretation
could hide an issue in a buggy generator.

Differential Revision: https://reviews.llvm.org/D73886


  Commit: cada5b881b6605b25ed203b57fa533bfb0d637b6
      https://github.com/llvm/llvm-project/commit/cada5b881b6605b25ed203b57fa533bfb0d637b6
  Author: Igor Kudrin <ikudrin at accesssoftek.com>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
    M llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/debug_frame_offset.test
    M llvm/test/tools/llvm-objdump/eh_frame-arm64.test
    M llvm/unittests/DebugInfo/DWARF/CMakeLists.txt
    A llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp

  Log Message:
  -----------
  [DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs.

This fixes printing long values that might reside in CIE and FDE,
including offsets, lengths, and addresses.

Differential Revision: https://reviews.llvm.org/D73887


Compare: https://github.com/llvm/llvm-project/compare/cd1dc7f15d63...cada5b881b66