[all-commits] [llvm/llvm-project] c6a389: [lldb] Delete two overloads of Disassembler::Disas...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c6a38957a7e5e2ec837470a62aff25abfbf6d397
      https://github.com/llvm/llvm-project/commit/c6a38957a7e5e2ec837470a62aff25abfbf6d397
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M lldb/include/lldb/Core/Disassembler.h
    M lldb/source/Commands/CommandObjectDisassemble.cpp
    M lldb/source/Core/Disassembler.cpp

  Log Message:
  -----------
  [lldb] Delete two overloads of Disassembler::Disassemble

by "inlining" them into their single caller (CommandObjectDisassemble).
The functions mainly consist of long argument lists and defensive
checks. These become unnecessary after inlining, so the end result is
less code. Additionally, this makes the implementation of
CommandObjectDisassemble more uniform (first figure out what you're
going to disassemble, then actually do it), which enables further
cleanups.