[all-commits] [llvm/llvm-project] df0586: Fix dyld opcode *_ADD_ADDR_IMM_SCALED error detect...

[Michael Trent via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: df058699d328598e636fa79684cca45857698e97
      https://github.com/llvm/llvm-project/commit/df058699d328598e636fa79684cca45857698e97
  Author: Michael Trent <mtrent at apple.com>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M llvm/lib/Object/MachOObjectFile.cpp
    M llvm/test/tools/llvm-objdump/macho-bad-bind.test

  Log Message:
  -----------
  Fix dyld opcode *_ADD_ADDR_IMM_SCALED error detection.

Summary:
Move the check for malformed REBASE_OPCODE_ADD_ADDR_IMM_SCALED and
BIND_OPCODE_DO_BIND_ADD_ADDR_IMM_SCALED opcodes after the immediate
has been applied to the SegmentOffset. This fixes specious errors
where SegmentOffset is pointing between two sections when trying to
correct the SegmentOffset value.

Update the regression tests to verify the proper error message.

Reviewers: pete, ab, lhames, steven_wu, jhenderson

Reviewed By: pete

Subscribers: hiraditya, dexonsmith, rupprecht, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75629