[all-commits] [llvm/llvm-project] 3906ae: [DAGCombine] Check the uses of negated floating co...

QingShan Zhang via All-commits all-commits at lists.llvm.org
Wed Mar 4 19:47:20 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3906ae387f0775dfe4426e4336748269fafbd190
      https://github.com/llvm/llvm-project/commit/3906ae387f0775dfe4426e4336748269fafbd190
  Author: QingShan Zhang <qshanz at cn.ibm.com>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/test/CodeGen/PowerPC/fma-combine.ll

  Log Message:
  -----------
  [DAGCombine] Check the uses of negated floating constant and remove the hack

PowerPC hits an assertion due to somewhat the same reason as https://reviews.llvm.org/D70975.
Though there are already some hack, it still failed with some case, when the operand 0 is NOT
a const fp, it is another fma that with const fp. And that const fp is negated which result in multi-uses.

A better fix is to check the uses of the negated const fp. If there are already use of its negated
value, we will have benefit as no extra Node is added.

Differential revision: https://reviews.llvm.org/D75501




More information about the All-commits mailing list