[all-commits] [llvm/llvm-project] 95a94d: [analyzer][NFC] Use CallEvent checker callback in ...

[Balazs Benics via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 95a94df5a9c3d7d2aa92b6beb13e82d8d5832e2e
      https://github.com/llvm/llvm-project/commit/95a94df5a9c3d7d2aa92b6beb13e82d8d5832e2e
  Author: Balazs Benics <benicsbalazs at gmail.com>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

  Log Message:
  -----------
  [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker

Summary:
Intended to be a non-functional change but it turned out CallEvent handles
constructor calls unlike CallExpr which doesn't triggered for constructors.

All in all, this change shouldn't be observable since constructors are not
yet propagating taintness like functions.
In the future constructors should propagate taintness as well.

This change includes:
 - NFCi change all uses of the CallExpr to CallEvent
 - NFC rename some functions, mark static them etc.
 - NFC omit explicit TaintPropagationRule type in switches
 - NFC apply some clang-tidy fixits

Reviewers: NoQ, Szelethus, boga95

Reviewed By: Szelethus

Subscribers: martong, whisperity, xazax.hun, baloghadamsoftware, szepet,
a.sidorin, mikhail.ramalho, donat.nagy, dkrupp, Charusso, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72035