[all-commits] [llvm/llvm-project] 3245dd: [lldb] Reduce duplication in CommandObjectDisassemble

Pavel Labath via All-commits all-commits at lists.llvm.org
Wed Mar 4 04:47:41 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3245dd59b124cbfce8cdce1f2c90e843d57d8722
      https://github.com/llvm/llvm-project/commit/3245dd59b124cbfce8cdce1f2c90e843d57d8722
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M lldb/source/Commands/CommandObjectDisassemble.cpp
    M lldb/test/Shell/Commands/Inputs/command-disassemble-process.lldbinit
    M lldb/test/Shell/Commands/command-disassemble-process.yaml

  Log Message:
  -----------
  [lldb] Reduce duplication in CommandObjectDisassemble

This command had nearly identical code for the "then" and "else"
branches of the "if (m_options.num_instructions != 0)" condition.

This patch factors out the common parts of the two blocks to reduce
duplication.




More information about the All-commits mailing list