[all-commits] [llvm/llvm-project] bca373: [clangd] DefineOutline won't copy virtual specifie...
Nathan James via All-commits
all-commits at lists.llvm.org
Wed Mar 4 00:15:31 PST 2020
Branch: refs/heads/release/10.x
Home: https://github.com/llvm/llvm-project
Commit: bca373f73fc82728a8335e7d6cd164e8747139ec
https://github.com/llvm/llvm-project/commit/bca373f73fc82728a8335e7d6cd164e8747139ec
Author: Nathan James <n.james93 at hotmail.co.uk>
Date: 2020-03-04 (Wed, 04 Mar 2020)
Changed paths:
M clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
M clang-tools-extra/clangd/unittests/TweakTests.cpp
Log Message:
-----------
[clangd] DefineOutline won't copy virtual specifiers on methods
Summary:
The define out of line refactor tool previously would copy the `virtual`, `override` and `final` specifier into the out of line method definition.
This results in malformed code as those specifiers aren't allowed outside the class definition.
Reviewers: hokein, kadircet
Reviewed By: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang, #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D75429
(cherry picked from commit b2666ccca0277371a09e43a0a5a0f78029ba81e5)
More information about the All-commits
mailing list