[all-commits] [llvm/llvm-project] 5b3b21: [DebugInfo] Fix for adding "returns cxx udt" optio...

Amy Huang via All-commits all-commits at lists.llvm.org
Tue Mar 3 14:00:33 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b3b21f0258899d03f6299fba6b4c78d7e730353
      https://github.com/llvm/llvm-project/commit/5b3b21f0258899d03f6299fba6b4c78d7e730353
  Author: Amy Huang <akhuang at google.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
    M llvm/test/DebugInfo/COFF/function-options.ll

  Log Message:
  -----------
  [DebugInfo] Fix for adding "returns cxx udt" option to functions in CodeView.

Summary:
This change checks for the return type in the frontend and adds a flag
to the DISubroutineType to indicate that the option should be added in
CodeViewDebug.

Previously function types sometimes appeared twice in the PDB: once with
"returns cxx udt" and once without.
See https://bugs.llvm.org/show_bug.cgi?id=44785.

Reviewers: rnk, asmith

Subscribers: hiraditya, cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D75215




More information about the All-commits mailing list