[all-commits] [llvm/llvm-project] 573e07: [lldb] Add detailed tests for the "disassemble" co...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 573e0776996425dd0567448d4a1f805a1f613e6d
      https://github.com/llvm/llvm-project/commit/573e0776996425dd0567448d4a1f805a1f613e6d
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    A lldb/test/Shell/Commands/Inputs/command-disassemble-process.lldbinit
    A lldb/test/Shell/Commands/Inputs/command-disassemble.lldbinit
    A lldb/test/Shell/Commands/command-disassemble-process.yaml
    A lldb/test/Shell/Commands/command-disassemble.s
    A lldb/test/Shell/Commands/lit.local.cfg

  Log Message:
  -----------
  [lldb] Add detailed tests for the "disassemble" command

While we have some tests for this command already, they are very vague.
This is not surprising -- it's hard to make strict assertions about the
assembly if your input is a c++ source file. This means that the tests
can more-or-less only detect when the command breaks completely, and not
when there is a subtle change in meaning due to e.g. a code refactor --
which is something that I am getting ready to do.

This tests in this patch create binaries with well known data (via assembler
and yaml2obj). This means that we are able to make precise assertions
about the text that lldb is supposed to print. As some of the features
of this command are only available with a real process, I use a minidump
core file to create a sufficiently realistic process object.