[all-commits] [llvm/llvm-project] 29a423: [Sema] Fix a crash when attaching comments to an i...

Erik Pilkington via All-commits all-commits at lists.llvm.org
Mon Mar 2 16:50:25 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 29a4239d31c6d8ccc557afbe0999aa096ca95cc6
      https://github.com/llvm/llvm-project/commit/29a4239d31c6d8ccc557afbe0999aa096ca95cc6
  Author: Erik Pilkington <erik.pilkington at gmail.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M clang/lib/AST/ASTContext.cpp
    M clang/test/Sema/warn-documentation.m

  Log Message:
  -----------
  [Sema] Fix a crash when attaching comments to an implicit decl

When an implicitly generated decl was the first entry in the group, we
attempted to lookup comments with an empty FileID, leading to crashes. Avoid
this by trying to use the other declarations in the group, and then bailing out
if none are valid.

rdar://59919733
Differential revision: https://reviews.llvm.org/D75483




More information about the All-commits mailing list