[all-commits] [llvm/llvm-project] 576883: Fix GSYM tests to run the yaml files and fix test ...

[Greg Clayton via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 57688350adea307e7bccb83b68a5b7333de31fd7
      https://github.com/llvm/llvm-project/commit/57688350adea307e7bccb83b68a5b7333de31fd7
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M llvm/lib/DebugInfo/GSYM/GsymCreator.cpp
    A llvm/test/tools/llvm-gsymutil/lit.local.cfg
    M llvm/tools/llvm-gsym/llvm-gsymutil.cpp

  Log Message:
  -----------
  Fix GSYM tests to run the yaml files and fix test failures on some machines.

YAML files were not being run during lit testing as there was no lit.local.cfg file. Once this was fixed, some buildbots would fail due to a StringRef that pointed to a std::string inside of a temporary llvm::Triple object. These issues are fixed here by making a local triple object that stays around long enough so the StringRef points to valid data. Also fixed an issue where strings for files in the file table could be added in opposite order due to parameters to function calls not having a strong ordering, which caused tests to fail.

Differential Revision: https://reviews.llvm.org/D75390