[all-commits] [llvm/llvm-project] 499b16: [CMake] Use PUBLIC link mode for static libraries

Reid Kleckner via All-commits all-commits at lists.llvm.org
Mon Mar 2 02:08:09 PST 2020


  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 499b1699621eb0aed9bec7017c1db60ccad30ae4
      https://github.com/llvm/llvm-project/commit/499b1699621eb0aed9bec7017c1db60ccad30ae4
  Author: Petr Hosek <phosek at google.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [CMake] Use PUBLIC link mode for static libraries

Using INTERFACE prevents the use of imported libraries as we've done
in 00b3d49 because these aren't linked against the target, they're
only made part of the interface. This doesn't affect the output since
static libraries aren't being linked into, but it enables the use of
imported libraries.

Differential Revision: https://reviews.llvm.org/D74106

(cherry picked from commit 50a6d3a6486d81d21a2c31ce8522321e19bed35e)


  Commit: 917119e95aa1e4ce99395f93f2eb696613c556ff
      https://github.com/llvm/llvm-project/commit/917119e95aa1e4ce99395f93f2eb696613c556ff
  Author: Petr Hosek <phosek at google.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M llvm/lib/Support/CMakeLists.txt

  Log Message:
  -----------
  [CMake] Link against ZLIB::ZLIB

This is the imported target that find_package(ZLIB) defines.

Differential Revision: https://reviews.llvm.org/D74176

(cherry picked from commit 2181bf40d87165ff4c208b46b135be823eef5c55)


  Commit: 6b16ce944fef5f3b30b7dcc001b3af478e038668
      https://github.com/llvm/llvm-project/commit/6b16ce944fef5f3b30b7dcc001b3af478e038668
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M llvm/lib/Support/CMakeLists.txt

  Log Message:
  -----------
  Attempt to fix ZLIB CMake logic on Windows

CMake doesn't seem to like it when you regex search for "^".

(cherry picked from commit 1079c68aa0fdb14d270a31c0df49a2afc5ed2485)


Compare: https://github.com/llvm/llvm-project/compare/f5fd8a37c184...6b16ce944fef


More information about the All-commits mailing list