[all-commits] [llvm/llvm-project] ca950a: [RISCV] Compress instructions based on function fe...

Simon Cook via All-commits all-commits at lists.llvm.org
Fri Feb 28 04:02:15 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ca950a6bb1972d142a8f6932f33f61386aabd949
      https://github.com/llvm/llvm-project/commit/ca950a6bb1972d142a8f6932f33f61386aabd949
  Author: Simon Cook <simon.cook at embecosm.com>
  Date:   2020-02-28 (Fri, 28 Feb 2020)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
    A llvm/test/CodeGen/RISCV/compress-float.ll
    M llvm/test/CodeGen/RISCV/compress.ll

  Log Message:
  -----------
  [RISCV] Compress instructions based on function features

When running under LTO, it is common to not specify the architecture
spec, which is used for setting up the target machine, and instead rely
on features specified in each function to generate the correct
instructions.

This works for the code generator, but the RISC-V backend uses the
AsmPrinter to do instruction compression, which does not see these
features but instead uses a MCSubtargetInfo object to see whether
compression is enabled. Since this is configured based on the
TargetMachine at startup, it will result in compressed instructions not
being emitted when it has not been given the 'c' TargetFeature, but the
function has it.

This changes the RISCVAsmPrinter to re-initialize the STI feature set
based on the current MachineFunction, such that compressed instructions
are now correctly emitted regardless of the method used to enable them.

Differential revision: https://reviews.llvm.org/D73339




More information about the All-commits mailing list