[all-commits] [llvm/llvm-project] d8392f: [mlir] Fix/clarify parts of MLIR toy tutorial chap...

Matthias Kramm via All-commits all-commits at lists.llvm.org
Thu Feb 27 17:52:10 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d8392f76bc659d5015b7e729792770d1e0e013ba
      https://github.com/llvm/llvm-project/commit/d8392f76bc659d5015b7e729792770d1e0e013ba
  Author: Matthias Kramm <kramm at google.com>
  Date:   2020-02-27 (Thu, 27 Feb 2020)

  Changed paths:
    M mlir/docs/Tutorials/Toy/Ch-4.md

  Log Message:
  -----------
  [mlir] Fix/clarify parts of MLIR toy tutorial chaper 4.

Summary:
* Let's use "override" when we're just doing standard baseclassing.
  ("Specialization" makes it sound like template specialization, which
   this is not.)
* CallInterfaces.td has an include guard, so #ifdef not needed anymore.
* Omit duplicate code in code samples.
* Clarify which algorithm we're talking about.
* Mention that the ShapeInference code is code a snippet that belongs to
  algorithm discussed in the paragraph above it.
* Add missing definition for createShapeInferencePass.

Differential Revision: https://reviews.llvm.org/D75260




More information about the All-commits mailing list