[all-commits] [llvm/llvm-project] 915e76: [arcconfig] Default base to previous revision

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Mon Feb 24 16:21:06 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 915e7699243726d001f9ab4e8fa2380a5e57de56
      https://github.com/llvm/llvm-project/commit/915e7699243726d001f9ab4e8fa2380a5e57de56
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-02-24 (Mon, 24 Feb 2020)

  Changed paths:
    M .arcconfig

  Log Message:
  -----------
  [arcconfig] Default base to previous revision

When you run `arc diff`, arc defaults to uploading all the changes you
have against the upstream branch into a single patch. This is almost
never what you want for stacked commits (patch series); you only want to
submit the changes done by the current patch. It's also come up as a
point of confusion in the Phabricator vs. GitHub PRs discussion, for
example. Configure arc to only upload your current patch by default,
which I think is a much more suitable default for LLVM developers.

Differential Revision: https://reviews.llvm.org/D74990


  Commit: e34ddc09f464667b5f3a49bf60255e89041ddf44
      https://github.com/llvm/llvm-project/commit/e34ddc09f464667b5f3a49bf60255e89041ddf44
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-02-24 (Mon, 24 Feb 2020)

  Changed paths:
    R clang-tools-extra/.arcconfig
    R clang/.arcconfig
    R compiler-rt/.arcconfig
    R debuginfo-tests/.arcconfig
    R libcxx/.arcconfig
    R libcxxabi/.arcconfig
    R libunwind/.arcconfig
    R lld/.arcconfig
    R lldb/.arcconfig
    R llvm/.arcconfig
    R openmp/.arcconfig
    R parallel-libs/.arcconfig
    R polly/.arcconfig
    R pstl/.arcconfig

  Log Message:
  -----------
  [arcconfig] Delete subproject arcconfigs

>From https://secure.phabricator.com/book/phabricator/article/arcanist_new_project/:

> An .arcconfig file is a JSON file which you check into your project's root.

I've done some experimentation, and it looks like the subproject
.arcconfigs just get ignored, as the documentation says. Given that
we're fully on the monorepo now, it's safe to remove them.

Differential Revision: https://reviews.llvm.org/D74996


Compare: https://github.com/llvm/llvm-project/compare/edc4f4c9c9d9...e34ddc09f464


More information about the All-commits mailing list