[all-commits] [llvm/llvm-project] bc4981: [clangd] Allow renaming class templates in cross-f...

Haojian Wu via All-commits all-commits at lists.llvm.org
Fri Feb 21 00:59:21 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bc498198b5559829d8f7138db01b0f51afefe2a7
      https://github.com/llvm/llvm-project/commit/bc498198b5559829d8f7138db01b0f51afefe2a7
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2020-02-21 (Fri, 21 Feb 2020)

  Changed paths:
    M clang-tools-extra/clangd/refactor/Rename.cpp
    M clang-tools-extra/clangd/unittests/RenameTests.cpp

  Log Message:
  -----------
  [clangd] Allow renaming class templates in cross-file rename.

Summary:
It was disabled because we don't handle explicit template
specialization well (due to the index limitation).

renaming templates is normal in practic, rather than disabling it, this patch
allows to rename them though it is not perfect (just a known limitation).

Context: https://github.com/clangd/clangd/issues/280

Reviewers: kbobyrev

Reviewed By: kbobyrev

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D74709




More information about the All-commits mailing list