[all-commits] [llvm/llvm-project] d4ded0: [libunwind][CMake] Treat S files as C to work arou...

Michael Spencer via All-commits all-commits at lists.llvm.org
Thu Feb 20 15:26:38 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d4ded05ba851304b26a437896bc3962ef56f62cb
      https://github.com/llvm/llvm-project/commit/d4ded05ba851304b26a437896bc3962ef56f62cb
  Author: Michael Spencer <bigcheesegs at gmail.com>
  Date:   2020-02-20 (Thu, 20 Feb 2020)

  Changed paths:
    M libunwind/src/CMakeLists.txt

  Log Message:
  -----------
  [libunwind][CMake] Treat S files as C to work around CMake bug.

The OSX_ARCHITECTURES property is supposed to add the -arch flag when
targeting Apple platforms. However, due to a bug in CMake
(https://github.com/Kitware/CMake/blob/master/Source/cmLocalGenerator.cxx#L1780),
this does not apply to assembly files. This results in a linker error
when trying to build libunwind for i386 on MacOS.

rdar://59642189




More information about the All-commits mailing list