[all-commits] [llvm/llvm-project] 0ffa6e: [lldb] Fix version string when using LLDB_REVISION...

[Jordan Rupprecht via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ffa6e1a7e1c5de36276375486f49277c6f95d0e
      https://github.com/llvm/llvm-project/commit/0ffa6e1a7e1c5de36276375486f49277c6f95d0e
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2020-02-20 (Thu, 20 Feb 2020)

  Changed paths:
    M lldb/source/lldb.cpp

  Log Message:
  -----------
  [lldb] Fix version string when using LLDB_REVISION but not LLDB_REPOSITORY

Summary:
lldb's format string (line one) is:
`lldb version $clang_version ($lldb_repo revision $lldb_revision)`

When only using $lldb_revision and not $lldb_repo, this might look like:
`lldb version 11 ( revision 12345)`
which looks pretty ugly.

Aside: I'm not sure we really need all the different versions since we've moved to the monorepo layout -- I don't think anyone is using different llvm/clang/lldb revisions, are they? We could likely tidy this up further if we knew how people consumed the output of lldb --version.

Reviewers: labath, JDevlieghere, friss

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74859