[all-commits] [llvm/llvm-project] 689f1e: [compiler-rt] [builtins] Fix logb / logbl tests

Luís Marques via All-commits all-commits at lists.llvm.org
Thu Feb 20 02:16:31 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 689f1e85ba68db7440451a6834095a52d1526b00
      https://github.com/llvm/llvm-project/commit/689f1e85ba68db7440451a6834095a52d1526b00
  Author: Luís Marques <luismarques at lowrisc.org>
  Date:   2020-02-20 (Thu, 20 Feb 2020)

  Changed paths:
    M compiler-rt/test/builtins/Unit/compiler_rt_logb_test.c
    M compiler-rt/test/builtins/Unit/compiler_rt_logbl_test.c

  Log Message:
  -----------
  [compiler-rt] [builtins] Fix logb / logbl tests

Like was done before in D67999 for `logbf`, this patch fixes the tests for
the internal compiler-rt implementations of `logb` and `logbl` to consider
all NaNs equivalent. Not doing so was resulting in test failures for
riscv64, since the the NaNs had different signs, but the spec doesn't
specify the NaN signedness or payload.

Fixes bug 44244.

Reviewers: rupprecht, delcypher
Reviewed By: rupprecht, delcypher
Differential Revision: https://reviews.llvm.org/D74826




More information about the All-commits mailing list