[all-commits] [llvm/llvm-project] fdea9a: [lldb] Remove license headers from all test source...

Wed Feb 19 23:32:30 PST 2020

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fdea9a4ec9b0d9585b8fe8a612686d9f44f40ddc
      https://github.com/llvm/llvm-project/commit/fdea9a4ec9b0d9585b8fe8a612686d9f44f40ddc
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-02-20 (Thu, 20 Feb 2020)

  Changed paths:
    M lldb/test/API/android/platform/main.cpp
    M lldb/test/API/api/check_public_api_headers/main.cpp.template
    M lldb/test/API/benchmarks/expression/main.cpp
    M lldb/test/API/commands/add-dsym/uuid/main.cpp.template
    M lldb/test/API/commands/apropos/with-process/main.cpp
    M lldb/test/API/commands/command/nested_alias/main.cpp
    M lldb/test/API/commands/command/script/main.cpp
    M lldb/test/API/commands/disassemble/basic/main.cpp
    M lldb/test/API/commands/expression/ir-interpreter-phi-nodes/main.cpp
    M lldb/test/API/commands/expression/persistent_types/main.c
    M lldb/test/API/commands/expression/persistent_variables/main.c
    M lldb/test/API/commands/expression/radar_8638051/main.c
    M lldb/test/API/commands/expression/radar_9531204/main.c
    M lldb/test/API/commands/expression/radar_9673664/main.c
    M lldb/test/API/commands/expression/save_jit_objects/main.c
    M lldb/test/API/commands/frame/recognizer/main.m
    M lldb/test/API/commands/frame/var-scope/main.c
    M lldb/test/API/commands/log/basic/main.cpp
    M lldb/test/API/commands/register/register/intel_xtended_registers/main.cpp
    M lldb/test/API/commands/register/register/intel_xtended_registers/mpx_bound_violation/main.cpp
    M lldb/test/API/commands/register/register/register_command/a.cpp
    M lldb/test/API/commands/register/register/register_command/main.cpp
    M lldb/test/API/commands/settings/main.cpp
    M lldb/test/API/commands/target/basic/a.c
    M lldb/test/API/commands/target/basic/b.c
    M lldb/test/API/commands/target/basic/c.c
    M lldb/test/API/commands/target/basic/globals.c
    M lldb/test/API/commands/target/create-deps/a.cpp
    M lldb/test/API/commands/target/create-deps/main.cpp
    M lldb/test/API/commands/watchpoints/hello_watchlocation/main.cpp
    M lldb/test/API/commands/watchpoints/hello_watchpoint/main.c
    M lldb/test/API/commands/watchpoints/multi_watchpoint_slots/main.c
    M lldb/test/API/commands/watchpoints/multiple_hits/main.cpp
    M lldb/test/API/commands/watchpoints/multiple_threads/main.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_commands/command/main.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_commands/condition/main.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_commands/main.c
    M lldb/test/API/commands/watchpoints/watchpoint_on_vectors/main.c
    M lldb/test/API/commands/watchpoints/watchpoint_set_command/main.cpp
    M lldb/test/API/commands/watchpoints/watchpoint_size/main.c
    M lldb/test/API/functionalities/archives/a.c
    M lldb/test/API/functionalities/archives/b.c
    M lldb/test/API/functionalities/archives/main.c
    M lldb/test/API/functionalities/asan/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
    M lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_command/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_conditions/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_hit_count/main.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_ids/main.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_ignore_count/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_names/main.c
    M lldb/test/API/functionalities/breakpoint/breakpoint_set_restart/main.cpp
    M lldb/test/API/functionalities/breakpoint/comp_dir_symlink/main.cpp
    M lldb/test/API/functionalities/breakpoint/consecutive_breakpoints/main.cpp
    M lldb/test/API/functionalities/breakpoint/cpp/main.cpp
    M lldb/test/API/functionalities/breakpoint/hardware_breakpoints/hardware_breakpoint_on_multiple_threads/main.cpp
    M lldb/test/API/functionalities/breakpoint/serialize/main.c
    M lldb/test/API/functionalities/conditional_break/main.c
    M lldb/test/API/functionalities/darwin_log/basic/main.c
    M lldb/test/API/functionalities/darwin_log/filter/exact_match/activity-chain/main.c
    M lldb/test/API/functionalities/darwin_log/filter/exact_match/activity/main.c
    M lldb/test/API/functionalities/darwin_log/filter/exact_match/category/main.c
    M lldb/test/API/functionalities/darwin_log/filter/exact_match/message/main.c
    M lldb/test/API/functionalities/darwin_log/filter/exact_match/subsystem/main.c
    M lldb/test/API/functionalities/darwin_log/filter/regex/activity-chain/main.c
    M lldb/test/API/functionalities/darwin_log/filter/regex/activity/main.c
    M lldb/test/API/functionalities/darwin_log/filter/regex/category/main.c
    M lldb/test/API/functionalities/darwin_log/filter/regex/message/main.c
    M lldb/test/API/functionalities/darwin_log/filter/regex/subsystem/main.c
    M lldb/test/API/functionalities/darwin_log/format/main.c
    M lldb/test/API/functionalities/darwin_log/source/debug/main.c
    M lldb/test/API/functionalities/darwin_log/source/info/main.c
    M lldb/test/API/functionalities/data-formatter/boolreference/main.mm
    M lldb/test/API/functionalities/data-formatter/compactvectors/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-advanced/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-categories/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-cpp/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-globals/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-named-summaries/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/cmtime/main.m
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/main.m
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsindexpath/main.m
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/nsstring/main.m
    M lldb/test/API/functionalities/data-formatter/data-formatter-proper-plurals/main.m
    M lldb/test/API/functionalities/data-formatter/data-formatter-ptr-to-array/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-script/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-smart-array/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/atomic/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/function/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/initializerlist/main.cpp
    M lldb/test/API/functionalities/data-formatter/data-formatter-synth/main.cpp
    M lldb/test/API/functionalities/data-formatter/dump_dynamic/main.cpp
    M lldb/test/API/functionalities/data-formatter/frameformat_smallstruct/main.cpp
    M lldb/test/API/functionalities/data-formatter/hexcaps/main.cpp
    M lldb/test/API/functionalities/data-formatter/language_category_updates/main.cpp
    M lldb/test/API/functionalities/data-formatter/nsarraysynth/main.m
    M lldb/test/API/functionalities/data-formatter/nsdictionarysynth/main.m
    M lldb/test/API/functionalities/data-formatter/nssetsynth/main.m
    M lldb/test/API/functionalities/data-formatter/ostypeformatting/main.mm
    M lldb/test/API/functionalities/data-formatter/parray/main.cpp
    M lldb/test/API/functionalities/data-formatter/poarray/main.mm
    M lldb/test/API/functionalities/data-formatter/ptr_ref_typedef/main.cpp
    M lldb/test/API/functionalities/data-formatter/pyobjsynthprovider/main.cpp
    M lldb/test/API/functionalities/data-formatter/setvaluefromcstring/main.m
    M lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp
    M lldb/test/API/functionalities/data-formatter/summary-string-onfail/main.cpp
    M lldb/test/API/functionalities/data-formatter/synthupdate/main.m
    M lldb/test/API/functionalities/data-formatter/typedef_array/main.cpp
    M lldb/test/API/functionalities/data-formatter/user-format-vs-summary/main.cpp
    M lldb/test/API/functionalities/data-formatter/var-in-aggregate-misuse/main.cpp
    M lldb/test/API/functionalities/data-formatter/vector-types/main.cpp
    M lldb/test/API/functionalities/dead-strip/main.c
    M lldb/test/API/functionalities/inferior-assert/main.c
    M lldb/test/API/functionalities/inferior-changed/main.c
    M lldb/test/API/functionalities/inferior-changed/main2.c
    M lldb/test/API/functionalities/inferior-crashing/main.c
    M lldb/test/API/functionalities/load_unload/a.cpp
    M lldb/test/API/functionalities/load_unload/b.cpp
    M lldb/test/API/functionalities/load_unload/c.cpp
    M lldb/test/API/functionalities/load_unload/d.cpp
    M lldb/test/API/functionalities/load_unload/hidden/d.cpp
    M lldb/test/API/functionalities/load_unload/main.cpp
    M lldb/test/API/functionalities/load_using_paths/hidden/d.cpp
    M lldb/test/API/functionalities/load_using_paths/main.cpp
    M lldb/test/API/functionalities/longjmp/main.c
    M lldb/test/API/functionalities/memory/cache/main.cpp
    M lldb/test/API/functionalities/memory/find/main.cpp
    M lldb/test/API/functionalities/memory/read/main.cpp
    M lldb/test/API/functionalities/non-overlapping-index-variable-i/main.cpp
    M lldb/test/API/functionalities/plugins/command_plugin/plugin.cpp.template
    M lldb/test/API/functionalities/postmortem/elf-core/gcore/main.cpp
    M lldb/test/API/functionalities/postmortem/elf-core/thread_crash/main.cpp
    M lldb/test/API/functionalities/ptr_refs/main.c
    M lldb/test/API/functionalities/recursion/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq1/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/ambiguous_tail_call_seq2/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/disambiguate_call_site/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/disambiguate_paths_to_common_sink/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/disambiguate_tail_call_seq/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/inlining_and_tail_calls/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/sbapi_support/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/thread_step_out_message/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/thread_step_out_or_return/main.cpp
    M lldb/test/API/functionalities/tail_call_frames/unambiguous_sequence/main.cpp
    M lldb/test/API/functionalities/thread/break_after_join/main.cpp
    M lldb/test/API/functionalities/thread/concurrent_events/main.cpp
    M lldb/test/API/functionalities/thread/crash_during_step/main.cpp
    M lldb/test/API/functionalities/thread/create_during_step/main.cpp
    M lldb/test/API/functionalities/thread/exit_during_break/main.cpp
    M lldb/test/API/functionalities/thread/exit_during_step/main.cpp
    M lldb/test/API/functionalities/thread/jump/main.cpp
    M lldb/test/API/functionalities/thread/jump/other.cpp
    M lldb/test/API/functionalities/thread/multi_break/main.cpp
    M lldb/test/API/functionalities/thread/state/main.cpp
    M lldb/test/API/functionalities/thread/step_out/main.cpp
    M lldb/test/API/functionalities/thread/thread_exit/main.cpp
    M lldb/test/API/functionalities/tsan/basic/main.c
    M lldb/test/API/functionalities/tsan/cpp_global_location/main.cpp
    M lldb/test/API/functionalities/tsan/global_location/main.c
    M lldb/test/API/functionalities/tsan/multiple/main.m
    M lldb/test/API/functionalities/tsan/thread_leak/main.c
    M lldb/test/API/functionalities/tsan/thread_numbers/main.c
    M lldb/test/API/functionalities/type_completion/main.cpp
    M lldb/test/API/functionalities/type_lookup/main.mm
    M lldb/test/API/functionalities/unwind/standard/hand_written/divmod.cpp
    M lldb/test/API/functionalities/unwind/standard/hand_written/fprintf.cpp
    M lldb/test/API/functionalities/unwind/standard/hand_written/new_delete.cpp
    M lldb/test/API/functionalities/value_md5_crash/main.cpp
    M lldb/test/API/issue_verification/inline_rerun_inferior.cpp
    M lldb/test/API/lang/c/array_types/main.c
    M lldb/test/API/lang/c/bitfields/main.c
    M lldb/test/API/lang/c/enum_types/main.c
    M lldb/test/API/lang/c/function_types/main.c
    M lldb/test/API/lang/c/global_variables/a.c
    M lldb/test/API/lang/c/global_variables/main.c
    M lldb/test/API/lang/c/set_values/main.c
    M lldb/test/API/lang/c/stepping/main.c
    M lldb/test/API/lang/c/strings/main.c
    M lldb/test/API/lang/c/struct_types/main.c
    M lldb/test/API/lang/c/tls_globals/a.c
    M lldb/test/API/lang/c/tls_globals/main.c
    M lldb/test/API/lang/c/typedef/main.c
    M lldb/test/API/lang/cpp/auto/main.cpp
    M lldb/test/API/lang/cpp/bool/main.cpp
    M lldb/test/API/lang/cpp/char1632_t/main.cpp
    M lldb/test/API/lang/cpp/class-template-parameter-pack/main.cpp
    M lldb/test/API/lang/cpp/class_static/main.cpp
    M lldb/test/API/lang/cpp/class_types/main.cpp
    M lldb/test/API/lang/cpp/const_this/main.cpp
    M lldb/test/API/lang/cpp/diamond/main.cpp
    M lldb/test/API/lang/cpp/dynamic-value/sbvalue-cast.cpp
    M lldb/test/API/lang/cpp/enum_types/main.cpp
    M lldb/test/API/lang/cpp/extern_c/main.cpp
    M lldb/test/API/lang/cpp/frame-var-anon-unions/main.cpp
    M lldb/test/API/lang/cpp/function-template-parameter-pack/main.cpp
    M lldb/test/API/lang/cpp/global_variables/main.cpp
    M lldb/test/API/lang/cpp/lambdas/main.cpp
    M lldb/test/API/lang/cpp/llvm-style/main.cpp
    M lldb/test/API/lang/cpp/namespace/main.cpp
    M lldb/test/API/lang/cpp/namespace/ns.cpp
    M lldb/test/API/lang/cpp/namespace/ns.h
    M lldb/test/API/lang/cpp/namespace/ns2.cpp
    M lldb/test/API/lang/cpp/namespace/ns3.cpp
    M lldb/test/API/lang/cpp/namespace_conflicts/main.cpp
    M lldb/test/API/lang/cpp/namespace_definitions/a.cpp
    M lldb/test/API/lang/cpp/namespace_definitions/b.cpp
    M lldb/test/API/lang/cpp/namespace_definitions/foo.h
    M lldb/test/API/lang/cpp/namespace_definitions/main.cpp
    M lldb/test/API/lang/cpp/printf/main.cpp
    M lldb/test/API/lang/cpp/signed_types/main.cpp
    M lldb/test/API/lang/cpp/static_members/main.cpp
    M lldb/test/API/lang/cpp/static_methods/main.cpp
    M lldb/test/API/lang/cpp/stl/main.cpp
    M lldb/test/API/lang/cpp/symbols/main.cpp
    M lldb/test/API/lang/cpp/template-function/main.cpp
    M lldb/test/API/lang/cpp/template/main.cpp
    M lldb/test/API/lang/cpp/this/main.cpp
    M lldb/test/API/lang/cpp/type_lookup/main.cpp
    M lldb/test/API/lang/cpp/unicode-literals/main.cpp
    M lldb/test/API/lang/cpp/unique-types/main.cpp
    M lldb/test/API/lang/cpp/unsigned_types/main.cpp
    M lldb/test/API/lang/cpp/wchar_t/main.cpp
    M lldb/test/API/lang/objc/bitfield_ivars/main.m
    M lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
    M lldb/test/API/lang/objc/exceptions/main.mm
    M lldb/test/API/lang/objc/print-obj/blocked.m
    M lldb/test/API/lang/objc/ptr_refs/main.m
    M lldb/test/API/lang/objc/self/main.m
    M lldb/test/API/lang/objc/variadic_methods/main.m
    M lldb/test/API/linux/builtin_trap/main.cpp
    M lldb/test/API/linux/thread/create_during_instruction_step/main.cpp
    M lldb/test/API/macosx/duplicate-archive-members/a.c
    M lldb/test/API/macosx/duplicate-archive-members/main.c
    M lldb/test/API/macosx/duplicate-archive-members/sub1/a.c
    M lldb/test/API/macosx/nslog/main.m
    M lldb/test/API/macosx/order/main.c
    M lldb/test/API/python_api/class_members/main.mm
    M lldb/test/API/python_api/event/main.c
    M lldb/test/API/python_api/exprpath_synthetic/main.mm
    M lldb/test/API/python_api/frame/get-variables/main.c
    M lldb/test/API/python_api/frame/main.c
    M lldb/test/API/python_api/function_symbol/main.c
    M lldb/test/API/python_api/lldbutil/frame/main.c
    M lldb/test/API/python_api/lldbutil/iter/main.cpp
    M lldb/test/API/python_api/lldbutil/process/main.cpp
    M lldb/test/API/python_api/objc_type/main.m
    M lldb/test/API/python_api/process/main.cpp
    M lldb/test/API/python_api/sbdata/main.cpp
    M lldb/test/API/python_api/sbtype_typeclass/main.m
    M lldb/test/API/python_api/section/main.c
    M lldb/test/API/python_api/signals/main.cpp
    M lldb/test/API/python_api/symbol-context/main.c
    M lldb/test/API/python_api/target/main.c
    M lldb/test/API/python_api/thread/main.cpp
    M lldb/test/API/python_api/thread/main2.cpp
    M lldb/test/API/python_api/type/main.cpp
    M lldb/test/API/python_api/value/empty_class/main.cpp
    M lldb/test/API/python_api/value/linked_list/main.cpp
    M lldb/test/API/python_api/value/main.c
    M lldb/test/API/python_api/watchpoint/condition/main.cpp
    M lldb/test/API/python_api/watchpoint/main.c
    M lldb/test/API/python_api/watchpoint/watchlocation/main.cpp
    M lldb/test/API/tools/lldb-server/libraries-svr4/main.cpp
    M lldb/test/API/tools/lldb-server/libraries-svr4/svr4lib_a.cpp
    M lldb/test/API/tools/lldb-server/libraries-svr4/svr4lib_b_quote.cpp
    M lldb/test/API/tools/lldb-server/main.cpp
    M lldb/test/API/tools/lldb-server/signal-filtering/main.cpp
    M lldb/test/Shell/ExecControl/StopHook/Inputs/stop-hook-2.lldbinit
    M lldb/test/Shell/ExecControl/StopHook/Inputs/stop-hook-3.lldbinit
    M lldb/test/Shell/ExecControl/StopHook/Inputs/stop-hook-threads.cpp
    M lldb/test/Shell/ExecControl/StopHook/Inputs/stop-hook.c
    M lldb/test/Shell/Reproducer/Inputs/GDBRemoteCapture.in
    M lldb/test/Shell/Reproducer/Inputs/GDBRemoteCrashCapture.in
    M lldb/test/Shell/Reproducer/Inputs/MultipleTargetsCapture.in
    M lldb/test/Shell/Reproducer/Inputs/simple.c
    M lldb/test/Shell/Reproducer/TestMultipleTargets.test

  Log Message:
  -----------
  [lldb] Remove license headers from all test source files

Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.

The reasons for this are:

* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.

For the record, the following tests had their line numbers changed to pass with the removal of the license header:
    lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
    lldb-shell :: Reproducer/TestGDBRemoteRepro.test
    lldb-shell :: Reproducer/TestMultipleTargets.test
    lldb-shell :: Reproducer/TestReuseDirectory.test
    lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
    lldb-shell :: ExecControl/StopHook/stop-hook.test
    lldb-api :: lang/objc/exceptions/TestObjCExceptions.py

Reviewers: #lldb, espindola, JDevlieghere

Reviewed By: #lldb, JDevlieghere

Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D74839