[all-commits] [llvm/llvm-project] 16aabc: [WebAssembly] Fix memory bug introduced in 5286180...

[Thomas Lively via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 16aabc86e0ab49dd9dc91dc4d0f71b3fbcdba2bf
      https://github.com/llvm/llvm-project/commit/16aabc86e0ab49dd9dc91dc4d0f71b3fbcdba2bf
  Author: Thomas Lively <tlively at google.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp

  Log Message:
  -----------
  [WebAssembly] Fix memory bug introduced in 52861809994c

Summary:
The instruction at `DefI` can sometimes be destroyed by
`rematerializeCheapDef`, so it should not be used after calling that
function. The fix is to use `Insert` instead when examining additional
multivalue stackifications. `Insert` is the address of the new
defining instruction after all moves and rematerializations have taken
place.

Reviewers: aheejin

Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74875