[all-commits] [llvm/llvm-project] 03954a: [AMDGPU] Fix DS_WRITE_B32 patterns

Stanislav Mekhanoshin via All-commits all-commits at lists.llvm.org
Wed Feb 19 13:42:26 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 03954a12aecbe77afb9c3ad47620305ec2675858
      https://github.com/llvm/llvm-project/commit/03954a12aecbe77afb9c3ad47620305ec2675858
  Author: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/DSInstructions.td

  Log Message:
  -----------
  [AMDGPU] Fix DS_WRITE_B32 patterns

It uses VGPR_32.RegTypes which includes 16 bit types. As a
result DS_WRITE_B32 may be generated for "store i16" which
is a bug. The only reason we do not hit it now is relative
patterns complexity and sorting. Should DS_WRITE_B16 pattern
complexity become higher and the bug appears.

Differential Revision: https://reviews.llvm.org/D74868




More information about the All-commits mailing list