[all-commits] [llvm/llvm-project] f6875c: Reapply [IRBuilder] Always respect inserter/folder

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Feb 19 12:02:35 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f6875c434ec20eb4f24495317592f64334347784
      https://github.com/llvm/llvm-project/commit/f6875c434ec20eb4f24495317592f64334347784
  Author: Nikita Popov <nikita.ppv at gmail.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M clang/test/OpenMP/parallel_codegen.cpp
    M clang/test/OpenMP/target_firstprivate_codegen.cpp
    M llvm/lib/IR/IRBuilder.cpp
    M llvm/test/Instrumentation/MemorySanitizer/Mips/vararg-mips64.ll
    M llvm/test/Instrumentation/MemorySanitizer/Mips/vararg-mips64el.ll
    M llvm/test/Instrumentation/MemorySanitizer/PowerPC/vararg-ppc64.ll
    M llvm/test/Instrumentation/MemorySanitizer/PowerPC/vararg-ppc64le.ll
    M llvm/test/Instrumentation/MemorySanitizer/X86/vararg_call.ll
    M llvm/test/Instrumentation/MemorySanitizer/byval-alignment.ll
    M llvm/test/Instrumentation/MemorySanitizer/msan_basic.ll
    M llvm/test/Transforms/InstCombine/saturating-add-sub.ll

  Log Message:
  -----------
  Reapply [IRBuilder] Always respect inserter/folder

Some IRBuilder methods that were originally defined on
IRBuilderBase do not respect custom IRBuilder inserters/folders,
because those were not accessible prior to D73835. Fix this by
making use of existing (and now accessible) IRBuilder methods,
which will handle inserters/folders correctly.

There are some changes in OpenMP and Instrumentation tests, where
bitcasts now get constant folded. I've also highlighted one
InstCombine test which now finishes in two rather than three
iterations, thanks to new instructions being inserted into the
worklist.

Differential Revision: https://reviews.llvm.org/D74787




More information about the All-commits mailing list