[all-commits] [llvm/llvm-project] 7751f0: Add testing for DW_OP_piece and fix a bug with sma...

[adrian-prantl via All-commits]

  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 7751f0c191518b377d9b71bdd17281abec83945a
      https://github.com/llvm/llvm-project/commit/7751f0c191518b377d9b71bdd17281abec83945a
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/unittests/Expression/DWARFExpressionTest.cpp

  Log Message:
  -----------
  Add testing for DW_OP_piece and fix a bug with small Scalar values.

By switching to Scalars that are backed by explicitly-sized APInts we
can avoid a bug that increases the buffer reserved for a small piece
to the next-largest host integer type.

This manifests as "DW_OP_piece for offset foo but top of stack is of size bar".

Differential Revision: https://reviews.llvm.org/D72879

(cherry picked from commit 7b0d58e339b271e3b1d9dc14b781b57fa0262e3a)


  Commit: cab81521b5afc2d4295f988aa5f087cbaeefb981
      https://github.com/llvm/llvm-project/commit/cab81521b5afc2d4295f988aa5f087cbaeefb981
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/unittests/Expression/DWARFExpressionTest.cpp

  Log Message:
  -----------
  Fix a buffer-size bug when the first DW_OP_piece is undefined

and document the shortcomings of LLDB's partially defined DW_OP_piece
handling.

This would manifest as "DW_OP_piece for offset foo but top of stack is
of size bar".

rdar://problem/46262998

Differential Revision: https://reviews.llvm.org/D72880

(cherry picked from commit f55ab6f90b7317a6bb85303a6102702bdae1199e)


Compare: https://github.com/llvm/llvm-project/compare/d5f8656a68c2...cab81521b5af