[all-commits] [llvm/llvm-project] 236fcb: Add coding standard recommending use of qualifiers...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Tue Feb 18 14:23:29 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 236fcbc21a7a88724240e818653fbb328a24bfbb
      https://github.com/llvm/llvm-project/commit/236fcbc21a7a88724240e818653fbb328a24bfbb
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-02-18 (Tue, 18 Feb 2020)

  Changed paths:
    M llvm/docs/CodingStandards.rst

  Log Message:
  -----------
  Add coding standard recommending use of qualifiers in cpp files

There is prior art for this in the code base itself, and a recent
example of this here: c45f8d49897f

This came up in discussion on this review where @maskray was going the
opposite direction:
  https://reviews.llvm.org/D68772

Given that there is disagreement, we should make a choice and document
it.

Thanks to John McCall for the precise wording.

Reviewed By: MaskRay, rjmccall

Differential Revision: https://reviews.llvm.org/D74515




More information about the All-commits mailing list