[all-commits] [llvm/llvm-project] 185ef6: [lldb] Don't call CopyForBreakpoint from a Breakpo...

[Tatyana Krasnukha via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 185ef697ef5c60d7a5c801925e6abdad52226c2b
      https://github.com/llvm/llvm-project/commit/185ef697ef5c60d7a5c801925e6abdad52226c2b
  Author: Tatyana Krasnukha <tatyana at synopsys.com>
  Date:   2020-02-18 (Tue, 18 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Breakpoint/Breakpoint.h
    M lldb/source/Breakpoint/Breakpoint.cpp
    M lldb/source/Target/Target.cpp
    M lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py

  Log Message:
  -----------
  [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

Some implementations (BreakpointResolverScripted) try calling the breakpoint's shared_from_this(),
that makes LLDB crash.


  Commit: b624b7dfd087809fb58bff0737750e75375fe450
      https://github.com/llvm/llvm-project/commit/b624b7dfd087809fb58bff0737750e75375fe450
  Author: Tatyana Krasnukha <tatyana at synopsys.com>
  Date:   2020-02-18 (Tue, 18 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Breakpoint/Breakpoint.h
    M lldb/include/lldb/Core/SearchFilter.h
    M lldb/source/Breakpoint/Breakpoint.cpp
    M lldb/source/Core/SearchFilter.cpp
    M lldb/source/Target/Target.cpp

  Log Message:
  -----------
  [lldb] Make shared_from_this-related code safer

Pass TargetSP to filters' CreateFromStructuredData, don't let them guess
whether target object is managed by a shared_ptr.

Make Breakpoint sure that m_target.shared_from_this() is safe by passing TargetSP
to all its static Create*** member-functions. This should be enough, since Breakpoint's
constructors are private/protected and never called directly (except by Target itself).


  Commit: 7fb06796abfd54878378b65456d567169d409bb3
      https://github.com/llvm/llvm-project/commit/7fb06796abfd54878378b65456d567169d409bb3
  Author: Tatyana Krasnukha <tatyana at synopsys.com>
  Date:   2020-02-18 (Tue, 18 Feb 2020)

  Changed paths:
    M lldb/include/lldb/Core/SearchFilter.h
    M lldb/include/lldb/Target/LanguageRuntime.h
    M lldb/source/Breakpoint/Breakpoint.cpp
    M lldb/source/Core/SearchFilter.cpp
    M lldb/source/Target/LanguageRuntime.cpp

  Log Message:
  -----------
  [lldb][NFC] Remove unused parameter

Rename search-filter's CopyForBreakpoint to CreateCopy, since they don't
do anything with breakpoints.


Compare: https://github.com/llvm/llvm-project/compare/d4576080da72...7fb06796abfd