[all-commits] [llvm/llvm-project] cf033e: [CMake] Fix setting result of libatomic check for ...

Luís Marques via All-commits all-commits at lists.llvm.org
Mon Feb 17 07:31:22 PST 2020


  Branch: refs/heads/fix-cmake-libatomic
  Home:   https://github.com/llvm/llvm-project
  Commit: cf033ed461001efd8160cdc54b58c71abd46c868
      https://github.com/llvm/llvm-project/commit/cf033ed461001efd8160cdc54b58c71abd46c868
  Author: Luís Marques <luismarques at lowrisc.org>
  Date:   2020-02-17 (Mon, 17 Feb 2020)

  Changed paths:
    M llvm/cmake/modules/CheckAtomic.cmake

  Log Message:
  -----------
  [CMake] Fix setting result of libatomic check for MSVC

We were skipping the libatomic requirement check for MSVC, but not setting
the corresponding variable, HAVE_CXX_ATOMICS_WITHOUT_LIB. D69869 seems to
have to failed to build on ARM MSVC because of that, and was reverted. This
should probably fix the issue. The plan is to check the result of the build
bots and then submit a more thoroughly refactored version for review.




More information about the All-commits mailing list