[all-commits] [llvm/llvm-project] 0acd7e: [mlir] Linalg: Extend promotion to non f32 buffers.

[poechsel via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0acd7e02f293378aeb2a4e1f8067a79ba5e04e6c
      https://github.com/llvm/llvm-project/commit/0acd7e02f293378aeb2a4e1f8067a79ba5e04e6c
  Author: Pierre Oechsel <pierre.oechsel at gmail.com>
  Date:   2020-02-17 (Mon, 17 Feb 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
    M mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
    M mlir/test/Dialect/Linalg/promote.mlir

  Log Message:
  -----------
  [mlir] Linalg: Extend promotion to non f32 buffers.

Summary:
Linalg's promotion pass was only supporting f32 buffers due to how the
zero value was build for the `fill` operation.

Moreover, `promoteSubViewOperands` was returning a vector with one entry
per float subview while omitting integer subviews. For a program
with only integer subviews the return vector would be of size 0.
However, `promoteSubViewsOperands` would try to access a non zero
number of entries of this vector, resulting in a sefgault.

Reviewers: nicolasvasilache, ftynse

Reviewed By: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D74532