[all-commits] [llvm/llvm-project] 39cb2a: [mlir] Fix argument attribute attribute reassignme...

ftynse via All-commits all-commits at lists.llvm.org
Fri Feb 14 01:22:39 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 39cb2a8fc79976171b20369ff756f7fa43232b50
      https://github.com/llvm/llvm-project/commit/39cb2a8fc79976171b20369ff756f7fa43232b50
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-02-14 (Fri, 14 Feb 2020)

  Changed paths:
    M mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp
    M mlir/test/Conversion/StandardToLLVM/convert-argattrs.mlir
    M mlir/test/Conversion/StandardToLLVM/convert-static-memref-ops.mlir

  Log Message:
  -----------
  [mlir] Fix argument attribute attribute reassignment in ConvertStandardToLLVM

The commit switching the calling convention for memrefs (5a1778057)
inadvertently introduced a bug in the function argument attribute conversion:
due to incorrect indexing of function arguments it was not assigning the
attributes to the arguments beyond those generated from the first original
argument. This was not caught in the commit since the test suite does have a
test for converting multi-argument functions with argument attributes. Fix the
bug and add relevant tests.




More information about the All-commits mailing list