[all-commits] [llvm/llvm-project] 9cb227: Stop emitting a breakpoint for each location in a ...

[Greg Clayton via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9cb227f561f4e5491840694580abbe7c0123b358
      https://github.com/llvm/llvm-project/commit/9cb227f561f4e5491840694580abbe7c0123b358
  Author: Greg Clayton <gclayton at fb.com>
  Date:   2020-02-13 (Thu, 13 Feb 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    A lldb/test/API/tools/lldb-vscode/breakpoint-events/Makefile
    A lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py
    A lldb/test/API/tools/lldb-vscode/breakpoint-events/foo.cpp
    A lldb/test/API/tools/lldb-vscode/breakpoint-events/foo.h
    A lldb/test/API/tools/lldb-vscode/breakpoint-events/main.cpp
    M lldb/tools/lldb-vscode/BreakpointBase.cpp
    M lldb/tools/lldb-vscode/BreakpointBase.h
    M lldb/tools/lldb-vscode/ExceptionBreakpoint.cpp
    M lldb/tools/lldb-vscode/FunctionBreakpoint.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/LLDBUtils.cpp
    M lldb/tools/lldb-vscode/LLDBUtils.h
    M lldb/tools/lldb-vscode/SourceBreakpoint.cpp
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands.

Summary: The VS Code DAP expects on response for each breakpoint that was requested. If we responsd with multiple entries for one breakpoint the VS Code UI gets out of date. Currently the VS code DAP doesn't handle one breakpoint with multiple locations. If this ever gets fixed we can modify our code.

Reviewers: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D73665