[all-commits] [llvm/llvm-project] 5ee4a0: [debuginfo-tests][Dexter] Fix some Windows-unfrien...

[Jeremy Morse via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ee4a03bc916d2925b9431c53b7da0d3ce7e2b9e
      https://github.com/llvm/llvm-project/commit/5ee4a03bc916d2925b9431c53b7da0d3ce7e2b9e
  Author: Jeremy Morse <jeremy.morse at sony.com>
  Date:   2020-02-13 (Thu, 13 Feb 2020)

  Changed paths:
    M debuginfo-tests/dexter/dex/debugger/Debuggers.py
    M debuginfo-tests/dexter/dex/tools/test/Tool.py
    M debuginfo-tests/lit.cfg.py

  Log Message:
  -----------
  [debuginfo-tests][Dexter] Fix some Windows-unfriendly Dexter behaviours

These are some minor things that I've run into on Windows, largely in
error handling paths:

 * Giving --lldb-executable on Windows triggers a "useless option" code
   path, which touches an attribute that only exists in the
   list_debuggers tool. Switch this to use hasattr, which will work in
   all subtools.
 * We were over-decoding some text reporting errors, but only in an
   exception path
 * The path to lldb on Windows needs to be quoted (even though dexter
   isn't making use of it).

Differential Revision: https://reviews.llvm.org/D74546