[all-commits] [llvm/llvm-project] e1b733: Fix a reentrance bug with deserializing ObjC type ...

[John McCall via All-commits]

  Branch: refs/heads/release/10.x
  Home:   https://github.com/llvm/llvm-project
  Commit: e1b73356879b1d9a8095de27e33943ae84d8f495
      https://github.com/llvm/llvm-project/commit/e1b73356879b1d9a8095de27e33943ae84d8f495
  Author: John McCall <rjmccall at apple.com>
  Date:   2020-02-13 (Thu, 13 Feb 2020)

  Changed paths:
    M clang/lib/Serialization/ASTReaderDecl.cpp
    M clang/test/Modules/Inputs/module.map
    A clang/test/Modules/Inputs/objc_type_param.h
    A clang/test/Modules/objc-type-param.m

  Log Message:
  -----------
  Fix a reentrance bug with deserializing ObjC type parameters.

This is a longstanding bug that seems to have been hidden by
a combination of (1) the normal flow being to deserialize the
interface before deserializing its parameter and (2) a precise
ordering of work that was apparently recently disturbed,
perhaps by my abstract-serialization work or Bruno's ObjC
module merging work.

Fixes rdar://59153545.

(cherry picked from commit 77b2ffc498e92cce7546d191f6712a3046300501)