[all-commits] [llvm/llvm-project] 687bbf: [llvm-exegesis] CombinationGenerator: don't store ...

[Roman Lebedev via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 687bbf85de4ae463c0794dff545734e194941162
      https://github.com/llvm/llvm-project/commit/687bbf85de4ae463c0794dff545734e194941162
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/SnippetGenerator.h
    M llvm/tools/llvm-exegesis/lib/X86/Target.cpp
    M llvm/unittests/tools/llvm-exegesis/SnippetGeneratorTest.cpp

  Log Message:
  -----------
  [llvm-exegesis] CombinationGenerator: don't store function_ref

function_ref is non-owning, so if we get it as a parameter in constructor,
our reference goes out-of-scope as soon as constructor returns.
Instead, let's just take it as a parameter to the actual `generate()` call