[all-commits] [llvm/llvm-project] 1da62b: [DebugInfo] Print version in error message in decimal

[James Henderson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1da62b51a5f00a4b84843f3ecc8a495de618afc8
      https://github.com/llvm/llvm-project/commit/1da62b51a5f00a4b84843f3ecc8a495de618afc8
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M lld/test/ELF/undef.s
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

  Log Message:
  -----------
  [DebugInfo] Print version in error message in decimal

Also remove some test duplication and add a test case that shows the
maximum version is rejected (this also shows that the value in the error
message is actually in decimal, and not just missing an 0x prefix).

Reviewed by: dblaikie

Differential Revision: https://reviews.llvm.org/D74403


  Commit: 23cf0a30b1528cf268ffdf13e04a5baa7eddfe0a
      https://github.com/llvm/llvm-project/commit/23cf0a30b1528cf268ffdf13e04a5baa7eddfe0a
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

  Log Message:
  -----------
  [DebugInfo] Add check for zero debug line opcode_base

The number of standard opcodes is defined to be opcode_base - 1, so a
value of 0 for the opcode_base caused a crash as an attempt was made to
reserve many entries in a vector. This change fixes the crash, by
issuing a warning and skipping reading of standard opcode lengths in the
event of an opcode_base of 0.

Reviewed by: dblaikie

Differential Revision: https://reviews.llvm.org/D74309


  Commit: bf4d8f29524449c4114b457875cc6a8031c46092
      https://github.com/llvm/llvm-project/commit/bf4d8f29524449c4114b457875cc6a8031c46092
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

  Log Message:
  -----------
  [DebugInfo] Add checks for v2 directory and file name table terminators

The DWARFv2-4 specification for the line table header states that the
include directories and file name tables both end with a single null
byte. Prior to this change, the parser did not detect if this byte was
missing, because it also stopped reading the tables once it reached the
prologue end, as claimed by the header_length field. This change adds a
check that the terminator has been seen at the end of each table.

Reviewed by: dblaikie, MaskRay

Differential Revision: https://reviews.llvm.org/D74413


Compare: https://github.com/llvm/llvm-project/compare/61b35e411116...bf4d8f295244