[all-commits] [llvm/llvm-project] fd11cd: [mlir] StdToLLVM: Add error when the sourceMemRef ...

[ftynse via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fd11cda2519f91e2f522f58f137b3082a65b5f62
      https://github.com/llvm/llvm-project/commit/fd11cda2519f91e2f522f58f137b3082a65b5f62
  Author: Pierre Oechsel <pierre.oechsel at gmail.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp
    A mlir/test/Conversion/StandardToLLVM/invalid.mlir

  Log Message:
  -----------
  [mlir] StdToLLVM: Add error when the sourceMemRef of a subview is not a llvm type.

A memref_cast casting to a memref with a non identity map can't be
lowered to llvm. Take the following case:

```

func @invalid_memref_cast(%arg0: memref<?x?xf64>) {
  %c1 = constant 1 : index
  %c0 = constant 0 : index
  %5 = memref_cast %arg0 : memref<?x?xf64> to memref<?x?xf64, #map1>
  %25 = std.subview %5[%c0, %c0][%c1, %c1][] : memref<?x?xf64, #map1> to memref<?x?xf64, #map1>
  return
}
```

When lowering the subview mlir was assuming `%5` to have an llvm type
(which is not the case as mlir failed to lower the memref_cast).

Differential Revision: https://reviews.llvm.org/D74466


  Commit: 5ae9c4c86806811cab3735dd56237ec1a9614354
      https://github.com/llvm/llvm-project/commit/5ae9c4c86806811cab3735dd56237ec1a9614354
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
    M mlir/test/Dialect/Linalg/fusion.mlir

  Log Message:
  -----------
  [mlir] Linalg fusion: ignore indexed_generic producers

They are currently not supported and we should not attempt fusing them.


Compare: https://github.com/llvm/llvm-project/compare/a19de32095e4...5ae9c4c86806