[all-commits] [llvm/llvm-project] 377a1c: [libcxx] Don't assume cwd name in std::filesystem ...

Sergej Jaskiewicz via All-commits all-commits at lists.llvm.org
Wed Feb 12 05:08:29 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 377a1c80e98951bb1c46b54c1f14400fba7f576f
      https://github.com/llvm/llvm-project/commit/377a1c80e98951bb1c46b54c1f14400fba7f576f
  Author: Sergej Jaskiewicz <jaskiewiczs at icloud.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.proximate/proximate.pass.cpp

  Log Message:
  -----------
  [libcxx] Don't assume cwd name in std::filesystem tests

Summary:
In `std::filesystem::proximate` tests we assume that the current working directory's name
is `fs.op.proximate`. This is fine when we're running the tests locally.

However, if we're running those tests on a remote machine via SSH, the directory layout may be
different. For example, currently we copy each test executable individually into
a temporary directory on the target board using SCP, so the assumption about the working directory name
doesn't necessarily hold.

This patch is the only thing that is necessary for all libc++ tests to pass when run remotely.

Reviewers: ldionne, EricWF, mclow.lists

Reviewed By: ldionne, EricWF

Subscribers: christof, dexonsmith, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D74348




More information about the All-commits mailing list