[all-commits] [llvm/llvm-project] a9a305: [mlir] Revise naming of MLIROptMain and MLIRMlirOp...

Marius Brehler via All-commits all-commits at lists.llvm.org
Wed Feb 12 00:46:14 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a9a305716bbfa657ce0f7ae9cd50df82720a6db0
      https://github.com/llvm/llvm-project/commit/a9a305716bbfa657ce0f7ae9cd50df82720a6db0
  Author: Marius Brehler <marius.brehler at iml.fraunhofer.de>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M mlir/lib/Support/CMakeLists.txt
    M mlir/tools/mlir-opt/CMakeLists.txt

  Log Message:
  -----------
  [mlir] Revise naming of MLIROptMain and MLIRMlirOptLib

* Rename CMake target MLIROptMain to MLIROptLib:
   The target provides the main library
* Rename CMake target MLIRMlirOptLib to MLIRMlirOptMain:
   The target provides the main() entry function

At the moment, the Bazel configuration of TenorFlow maps the target
MlirOptLib to "lib/Support/MlirOptMain.cpp" and MlirOptMain to
"tools/mlir-opt/mlir-opt.cpp". This is the other way around in the CMake
configuration. As discussed in the context of the pull request
https://github.com/tensorflow/tensorflow/pull/36301, it seems useful to
revise the naming in the MLIR repo.

Differential Revision: https://reviews.llvm.org/D73778




More information about the All-commits mailing list