[all-commits] [llvm/llvm-project] 6d4eba: AMDGPU: Use conditions directly in division expansion

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Feb 11 20:11:52 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6d4ebada797f22f1bdb9bf07f7e51671d6af458c
      https://github.com/llvm/llvm-project/commit/6d4ebada797f22f1bdb9bf07f7e51671d6af458c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-11 (Tue, 11 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
    M llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-fold-binop-select.ll
    M llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll

  Log Message:
  -----------
  AMDGPU: Use conditions directly in division expansion

This was creating a select on true/false values, and then comparing
that later. This produced more work for later combines, which can be
avoided by just using the boolean values. This was copied from the
original DAG expansion, which also has the same problem. This doesn't
have a observable change using SelectionDAG, but since GlobalISel is
missing these optimizations, the final code was noticeably longer.




More information about the All-commits mailing list