[all-commits] [llvm/llvm-project] 642bc1: [lldb][NFC] Remove several inefficient ConstString...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 642bc15dd7186a6317510cf961a8dc3d35e5b713
      https://github.com/llvm/llvm-project/commit/642bc15dd7186a6317510cf961a8dc3d35e5b713
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-02-11 (Tue, 11 Feb 2020)

  Changed paths:
    M lldb/include/lldb/DataFormatters/FormattersContainer.h
    M lldb/include/lldb/Expression/IRExecutionUnit.h
    M lldb/source/Breakpoint/BreakpointResolverName.cpp
    M lldb/source/Core/Debugger.cpp
    M lldb/source/Core/DynamicLoader.cpp
    M lldb/source/Core/FormatEntity.cpp
    M lldb/source/Core/Mangled.cpp
    M lldb/source/Core/ModuleList.cpp
    M lldb/source/Core/ValueObject.cpp
    M lldb/source/Core/ValueObjectRegister.cpp
    M lldb/source/Expression/IRExecutionUnit.cpp
    M lldb/source/Expression/REPL.cpp
    M lldb/source/Expression/UserExpression.cpp
    M lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
    M lldb/source/Target/UnixSignals.cpp
    M lldb/source/Utility/Broadcaster.cpp
    M lldb/source/Utility/ConstString.cpp
    M lldb/source/Utility/StructuredData.cpp
    M lldb/tools/lldb-server/lldb-platform.cpp

  Log Message:
  -----------
  [lldb][NFC] Remove several inefficient ConstString -> const char * -> StringRef conversions

StringRef will call strlen on the C string which is inefficient (as ConstString already
knows the string lenght and so does StringRef). This patch replaces all those calls
with GetStringRef() which doesn't recompute the length.