[all-commits] [llvm/llvm-project] 85515c: [libFuzzer] communicate through pipe to subprocess...

[Yuanfang Chen via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 85515c7fd53c0cb77ccf46eaa5246ac61ae08ee8
      https://github.com/llvm/llvm-project/commit/85515c7fd53c0cb77ccf46eaa5246ac61ae08ee8
  Author: Yuanfang Chen <yuanfang.chen at sony.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M compiler-rt/lib/fuzzer/FuzzerDriver.cpp
    M compiler-rt/lib/fuzzer/FuzzerUtil.h
    M compiler-rt/lib/fuzzer/FuzzerUtilPosix.cpp
    M compiler-rt/lib/fuzzer/FuzzerUtilWindows.cpp

  Log Message:
  -----------
  [libFuzzer] communicate through pipe to subprocess for MinimizeCrashInput

For CleanseCrashInput, discards stdout output anyway since it is not used.

These changes are to defend against aggressive PID recycle on windows to reduce the chance of contention on files.

Using pipe instead of file also workaround the problem that when the
process is spawned by llvm-lit, the aborted process keeps a handle to the
output file such that the output file can not be removed. This will
cause random test failures.

https://devblogs.microsoft.com/oldnewthing/20110107-00/?p=11803

Reviewers: kcc, vitalybuka

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D73329


  Commit: 8a29cb4421f1196bc40c4db5298ca13df516bf19
      https://github.com/llvm/llvm-project/commit/8a29cb4421f1196bc40c4db5298ca13df516bf19
  Author: Yuanfang Chen <yuanfang.chen at sony.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M compiler-rt/lib/fuzzer/FuzzerDriver.cpp
    M compiler-rt/lib/fuzzer/FuzzerFork.cpp
    M compiler-rt/lib/fuzzer/FuzzerIO.cpp
    M compiler-rt/lib/fuzzer/FuzzerIO.h
    M compiler-rt/lib/fuzzer/FuzzerLoop.cpp

  Log Message:
  -----------
  [NFC][libFuzzer] Prefix TempPath with string showing the work it is doing.


Compare: https://github.com/llvm/llvm-project/compare/09d26b79d295...8a29cb4421f1