[all-commits] [llvm/llvm-project] 75394e: [mlir][EDSC] Almost NFC - Refactor and untangle ED...

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Mon Feb 10 09:13:43 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 75394e1301dd1d4739a24d440e9996c52e5b5570
      https://github.com/llvm/llvm-project/commit/75394e1301dd1d4739a24d440e9996c52e5b5570
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M mlir/docs/EDSC.md
    A mlir/include/mlir/Dialect/AffineOps/EDSC/Builders.h
    A mlir/include/mlir/Dialect/AffineOps/EDSC/Intrinsics.h
    M mlir/include/mlir/Dialect/Linalg/EDSC/Builders.h
    M mlir/include/mlir/Dialect/Linalg/EDSC/Intrinsics.h
    A mlir/include/mlir/Dialect/LoopOps/EDSC/Builders.h
    A mlir/include/mlir/Dialect/StandardOps/EDSC/Builders.h
    A mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h
    M mlir/include/mlir/EDSC/Builders.h
    R mlir/include/mlir/EDSC/Helpers.h
    M mlir/include/mlir/EDSC/Intrinsics.h
    M mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
    M mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp
    M mlir/lib/Dialect/AffineOps/CMakeLists.txt
    A mlir/lib/Dialect/AffineOps/EDSC/Builders.cpp
    M mlir/lib/Dialect/GPU/Transforms/MemoryPromotion.cpp
    M mlir/lib/Dialect/Linalg/EDSC/Builders.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp
    M mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
    M mlir/lib/Dialect/Linalg/Utils/Utils.cpp
    M mlir/lib/Dialect/LoopOps/CMakeLists.txt
    A mlir/lib/Dialect/LoopOps/EDSC/Builders.cpp
    M mlir/lib/Dialect/StandardOps/CMakeLists.txt
    A mlir/lib/Dialect/StandardOps/EDSC/Builders.cpp
    A mlir/lib/Dialect/StandardOps/EDSC/Intrinsics.cpp
    M mlir/lib/EDSC/Builders.cpp
    M mlir/lib/EDSC/CMakeLists.txt
    R mlir/lib/EDSC/Helpers.cpp
    R mlir/lib/EDSC/Intrinsics.cpp
    M mlir/test/EDSC/builder-api-test.cpp

  Log Message:
  -----------
  [mlir][EDSC] Almost NFC - Refactor and untangle EDSC dependencies

This CL refactors EDSCs to layer them better and break unnecessary
dependencies. After this refactoring, the top-level EDSC target only
depends on IR but not on Dialects anymore and each dialect has its
own EDSC directory.

This simplifies the layering and breaks cyclic dependencies.
In particular, the declarative builder + folder are made explicit and
are now confined to Linalg.

As the refactoring occurred, certain classes and abstractions that were not
paying for themselves have been removed.

Differential Revision: https://reviews.llvm.org/D74302




More information about the All-commits mailing list