[all-commits] [llvm/llvm-project] 0151dd: Create a clang-tidy check to warn when -dealloc is...

[Michael Wyman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0151ddc2e834ab4949789cbed4e03a958284cd54
      https://github.com/llvm/llvm-project/commit/0151ddc2e834ab4949789cbed4e03a958284cd54
  Author: Michael Wyman <michael at mwyman.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M clang-tools-extra/clang-tidy/objc/CMakeLists.txt
    A clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp
    A clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.h
    M clang-tools-extra/clang-tidy/objc/ObjCTidyModule.cpp
    M clang-tools-extra/docs/ReleaseNotes.rst
    M clang-tools-extra/docs/clang-tidy/checks/list.rst
    A clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-category.rst
    A clang-tools-extra/test/clang-tidy/checkers/objc-dealloc-in-category.m

  Log Message:
  -----------
  Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

Summary: Such implementations may override the class's own implementation, and even be a danger in case someone later comes and adds one to the class itself. Most times this has been encountered have been a mistake.

Reviewers: stephanemoore, benhamilton, dmaclach

Reviewed By: stephanemoore, benhamilton, dmaclach

Subscribers: dmaclach, mgorny, cfe-commits

Tags: #clang-tools-extra, #clang

Differential Revision: https://reviews.llvm.org/D72876