[all-commits] [llvm/llvm-project] 5ad62d: [compiler-rt] Some clean up / refactoring in sanit...
Max Moroz via All-commits
all-commits at lists.llvm.org
Mon Feb 10 07:03:42 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 5ad62d3b7f7e75df776a4524bda0c9a1a9952a4e
https://github.com/llvm/llvm-project/commit/5ad62d3b7f7e75df776a4524bda0c9a1a9952a4e
Author: Max Moroz <mmoroz at chromium.org>
Date: 2020-02-10 (Mon, 10 Feb 2020)
Changed paths:
M compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp
Log Message:
-----------
[compiler-rt] Some clean up / refactoring in sanitizer_symbolizer_libcdep.cpp.
Summary:
Nothing critical, just a few potential improvements I've noticed while reading
the code:
- return `false` when symbolizer buffer is too small to read all data
- invert some conditions to reduce indentation
- prefer `nullptr` over `0` for pointers; init some pointers on stack;
- remove minor code duplication
Reviewers: eugenis, vitalybuka
Subscribers: dberris, #sanitizers, llvm-commits, kcc
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D74137
More information about the All-commits
mailing list