[all-commits] [llvm/llvm-project] 1dc62d: [DebugInfo][test] Replace pre-canned binary test

[James Henderson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1dc62d0358c89d3e5db970e62723fa8b0b0c56e3
      https://github.com/llvm/llvm-project/commit/1dc62d0358c89d3e5db970e62723fa8b0b0c56e3
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    R llvm/test/DebugInfo/Inputs/invalid.linetable
    R llvm/test/DebugInfo/dwarfdump-invalid-line-table.test
    M llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
    M llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    M llvm/unittests/DebugInfo/DWARF/DWARFFormValueTest.cpp

  Log Message:
  -----------
  [DebugInfo][test] Replace pre-canned binary test

The DebugInfo/dwarfdump-invalid-line-table test used a pre-canned binary
generated by a fuzzer to demonstrate a bug fix. Unfortunately, the
binary is rigid and requires hand-editing if we change behaviour, such
as rejecting certain properties within it (as I plan on doing in another
change).

Rather than hand-edit the binary, I have replaced it with two tests. The
first tests the high-level code path from the debug line parser that
produces the same error as this test previously did, and the second is a
set of unit test cases that comprehensively cover the
FormValue::skipValue method, which in turn covers the area that the
original bug fix touched.

Reviewed by: MaskRay, dblaikie

Differential Revision: https://reviews.llvm.org/D74202