[all-commits] [llvm/llvm-project] 3dc479: [gn build] make 'clang' target depend on libcxx/in...

[Nico Weber via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3dc47979bb9eb99e5bec5fb33215d256cbaa3eb1
      https://github.com/llvm/llvm-project/commit/3dc47979bb9eb99e5bec5fb33215d256cbaa3eb1
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M llvm/utils/gn/secondary/clang/tools/driver/BUILD.gn
    M llvm/utils/gn/secondary/libcxx/include/BUILD.gn

  Log Message:
  -----------
  [gn build] make 'clang' target depend on libcxx/include on mac

On macOS, libc++ headers are distributed with the compiler, not
the sysroot. Without this, compiling a file that includes something
like <string> won't compile with gn-built clang without manual tweaks.

I used to do the manual tweaks, but now that other people are starting
to use this on mac, let's make it Just Work.

(This is marginally nicer than the cmake build now in that you can
just build 'clang' and it'll do the right thing.)

Differential Revision: https://reviews.llvm.org/D74247