[all-commits] [llvm/llvm-project] 6e1770: AMDGPU: Fix SI_IF lowering when the save exec reg ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sun Feb 9 14:59:38 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6e1770821fbd05bd5180530aca17e1455d1c29d8
      https://github.com/llvm/llvm-project/commit/6e1770821fbd05bd5180530aca17e1455d1c29d8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-09 (Sun, 09 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp
    A llvm/test/CodeGen/AMDGPU/si-if-lower-user-terminators.mir

  Log Message:
  -----------
  AMDGPU: Fix SI_IF lowering when the save exec reg has terminator uses

Reverts part of 6524a7a2b9ca072bd7f7b4355d1230e70c679d2f. Since that
commit, the expansion was ignoring the actual save exec register
produced by the instruction, and looking at other instructions. I do
not understand why it was looking at other instructions, but relying
on this scan was wrong.

Fixes verifier errors after SI_IF is tail duplicated, which should be
correct to do. The results were fed into a phi, which was lowered to
the S_MOV_B64_term instructions.


  Commit: 00115d767f34ecab35f86c29f37593efadd2b327
      https://github.com/llvm/llvm-project/commit/00115d767f34ecab35f86c29f37593efadd2b327
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-02-09 (Sun, 09 Feb 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td

  Log Message:
  -----------
  AMDGPU: Remove dead kill handling

At one point a custom node was used for kill handling, but now the
intrinsic is directly selected. Remove leftover pattern machinery.


Compare: https://github.com/llvm/llvm-project/compare/29e646fe655c...00115d767f34


More information about the All-commits mailing list